Skip to content

JSON API, flask server#24

Merged
bmaranville merged 72 commits intopython-periodictable:masterfrom
bmaranville:deduplicate-html
Mar 3, 2026
Merged

JSON API, flask server#24
bmaranville merged 72 commits intopython-periodictable:masterfrom
bmaranville:deduplicate-html

Conversation

@bmaranville
Copy link
Contributor

@bmaranville bmaranville commented Feb 27, 2026

This PR:

  • replaces the cgi_call function that works directly with a CGI request object, with a dict-based api_call function
  • removes the CGI demo server
  • adds a Flask demo server
  • replaces duplicate HTML files with a single index_template.html
    • rendered with built-in renderer in flask server
    • rendered with sed statements in deploy.sh script

bmaranville added 30 commits June 16, 2022 16:42
@bmaranville
move creation of form object outside cgi_call
5b53f02
@bmaranville
adding pyodide version of calculator
5bfa08a
@bmaranville
remove debugging statement
a716abb
@bmaranville
make worker_ready message more distinct
058c936
@bmaranville
fix call to cgi_call
1d5488f
@bmaranville
adding service worker version of page
2bfb988
@bmaranville
adding message back to client(s) when service worker is ready
57e4173
@bmaranville
improve loading lifecycle for python code
bd45628
@bmaranville
adding check for hard refresh - does a second soft reload to re-activ…
62251d0 
…ate the service worker
@bmaranville
use separate fetch command to make sure pyodide is ready
0ba99c9
@bmaranville
udpate pyodide version
e81baa3
@bmaranville
Merge branch 'python-periodictable:master' into master
fd68a34
@bmaranville
updates from upstream index.html
856f0d7
@bmaranville
revert payload extraction from event
aa97983
@bmaranville
wait for the worker to be ready
1d78352
@bmaranville
Merge remote-tracking branch 'upstream/master'
50ee09e
@bmaranville
Merge remote-tracking branch 'origin/master' into pyodide
69f40fa
@bmaranville
make cgi a lazy import
3439f40
@bmaranville
update pyodide version
0a00757
@bmaranville
update pyodide version
faea11d
@bmaranville
adding new version that allows immediate interaction with the page
8e49aa8
@bmaranville
use module webworker
0c0d834
@bmaranville
add workflow for deploying to gh-pages
d56564d
@bmaranville
add script for getting static pyodide libraries we need
c5dca96
@bmaranville
use new script for getting pyodide
1c99490
@bmaranville
use local pyodide
e469fe9
@bmaranville
use local nact.py
1ed74f5
@bmaranville
add favicon.ico to site
c706e2c
@bmaranville
adding deploy script
bdeb709
@bmaranville
add helper file that contains full path to periodictable local wheel
bd3fb8d
@bmaranville
just pass JSON
63ed18c
@bmaranville
default index.html is webworker version (replaced in local servers)
fd605fb
@bmaranville
nact.py api_call takes a plain dict (JSON) now, no need to fake CGI f…
a1fe2e1 
…ield storage
@bmaranville
json dict always includes mass, even if empty, so handle that, and ex…
2714602 
…pect rest to be string of comma-separated values
@bmaranville
add regex replace to load the api_cgi.js API in the page, replacing a…
79d8bda 
…pi_webworker.js
@bmaranville
update readme for json API and flask server
d46b321
@bmaranville
remove server.py, replace with flask_server.py and cgi_server.py
4f6cd2e
@bmaranville
use index_template, and render it with periodictable version and webw…
f59b588 
…orker api script
@bmaranville
removing deprecated files
23d76c3
@bmaranville
adding flask server
dc050d9
@bmaranville
update sample query
422e5b6
@bmaranville
replacing duplicate html with single index_template.html
785bed8
@bmaranville
need css and all js scripts in deployment
d1aa1d9
@bmaranville bmaranville mentioned this pull request Feb 27, 2026
Closed
pkienzle
pkienzle reviewed Feb 27, 2026
View reviewed changes
Copy link
Contributor

@pkienzle pkienzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the flask version and the pyodide version work. Need to update the readme and fix the sed commands in deploy_calculator.sh before merging.

I didn't test the deploy workflow.

@pkienzle
Copy link
Contributor

pkienzle commented Feb 27, 2026

Add activation/pyodide and activation/periodictable_wheel_name.txt to .gitignore.

@pkienzle
Copy link
Contributor

pkienzle commented Feb 27, 2026

Help needs updating. The changes are in #22 but I doubt it will merge cleanly after the reshuffle.

@bmaranville
Copy link
Contributor Author

bmaranville commented Mar 3, 2026

Help needs updating. The changes are in #22 but I doubt it will merge cleanly after the reshuffle.

Yes, I had to merge the changes in manually. But it's done.

@bmaranville bmaranville requested a review from pkienzle March 3, 2026 16:19
@bmaranville bmaranville merged commit 3c49f58 into python-periodictable:master Mar 3, 2026
@bmaranville bmaranville deleted the deduplicate-html branch March 3, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkienzle pkienzle pkienzle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bmaranville @pkienzle